add documentation for NIC statefulset #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
vepatel
changed the title
AlexFenlon
reviewed
Sep 10, 2025
There was a problem hiding this comment.
Pull Request Overview
Adds documentation for NGINX Ingress Controller StatefulSet deployment type to support NIC v3.8.0 which introduces StatefulSet as a new deployment option alongside existing Deployment and DaemonSet types. The changes ensure comprehensive coverage of all three deployment methods in installation guides, configuration references, and troubleshooting documentation.
- Updates installation documentation to include StatefulSet as a third deployment option
- Adds StatefulSet-specific configuration parameters in Helm chart documentation
- Updates troubleshooting and logging guides to reference StatefulSet alongside Deployment/DaemonSet
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| content/nic/tutorials/oidc-custom-configuration.md | Updates OIDC tutorial to include StatefulSet in volume mount instructions |
| content/nic/troubleshooting/troubleshoot-common.md | Adds StatefulSet reference to troubleshooting commands |
| content/nic/overview/product-telemetry.md | Updates telemetry description to include StatefulSet replicas |
| content/nic/logging-and-monitoring/service-insight.md | Includes StatefulSet in Service Insight installation options |
| content/nic/logging-and-monitoring/prometheus.md | Updates Prometheus metrics guide to reference StatefulSet |
| content/nic/installation/integrations/app-protect-waf/installation.md | Adds StatefulSet deployment option and volume configuration notes |
| content/nic/installation/integrations/app-protect-waf-v5/installation.md | Includes StatefulSet in WAF v5 installation with volume guidance |
| content/nic/installation/integrations/app-protect-dos/installation.md | Adds StatefulSet option to DoS installation guide |
| content/nic/installation/installing-nic/installation-with-manifests.md | Updates main installation guide to include StatefulSet as third deployment option |
| content/nic/installation/installing-nic/installation-with-helm.md | Adds StatefulSet-specific Helm chart parameters and configuration options |
| content/nic/configuration/global-configuration/configmap-resource.md | Updates ConfigMap documentation to reference StatefulSet in zone-sync |
| content/includes/nic/installation/manifests/statefulset.md | New include file with StatefulSet deployment instructions |
| content/includes/nic/configuration/security.md | Updates security recommendations for StatefulSet volume configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
content/nic/installation/integrations/app-protect-waf-v5/installation.md
Show resolved
Hide resolved
✅ Deploy Preview will be available once build job completes!
|
AlexFenlon
approved these changes
Sep 10, 2025
nginx-jack
reviewed
Sep 10, 2025
content/nic/installation/integrations/app-protect-waf/installation.md
Outdated
Show resolved
Hide resolved
haywoodsh
approved these changes
Sep 10, 2025
ADubhlaoich
approved these changes
Sep 10, 2025
JTorreG
reviewed
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
StatefulSetNIC PR: StatefulSet support kubernetes-ingress#8159
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩